git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 03/23] archive-zip.c: mark more strings for translation

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 19, 2018, 18:26 UTC
Message-ID
<xmqqin5bf5fp.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20180718161101.19765-4-pclouds@gmail.com>
Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:
> -		return error("path too long (%d chars, SHA1: %s): %s",
> +		return error(_("path too long (%d chars, SHA1: %s): %s"),
> -		return error("unsupported file mode: 0%o (SHA1: %s)", mode,
> +		return error(_("unsupported file mode: 0%o (SHA1: %s)"), mode,
The same #leftoverbits comment as 02/23 applies here.
Show 7 quoted lines
> @@ -601,7 +601,7 @@ static void dos_time(timestamp_t *timestamp, int *dos_date, int *dos_time)
>  	struct tm *t;
>  
>  	if (date_overflows(*timestamp))
> -		die("timestamp too large for this system: %"PRItime,
> +		die(_("timestamp too large for this system: %"PRItime),
>  		    *timestamp);

I suspect that this won't do the right "cross-platform" thing. For built-in PRItype formats gettext tool knows about, *.po files let translators translate original with "%<PRItype>" into localized text with the same "%<PRItype>" left, and the runtime does the right thing, but for a custom format like PRItime there is no such support.

Previous: Nguyễn Thái Ngọc DuyNext: Duy Nguyen
Message 6 of 58 in “Mark strings for translation”
  1. 00/23 Mark strings for translationNguyễn Thái Ngọc Duy, Jul 18, 2018
  2. 02/23 archive-tar.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 18, 2018
  3. Junio C HamanoJul 19, 2018
  4. Duy NguyenJul 21, 2018
  5. 03/23 archive-zip.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 18, 2018
  6. Junio C HamanoJul 19, 2018
  7. Duy NguyenJul 19, 2018
  8. Junio C HamanoJul 19, 2018
  9. 01/23 Update messages in preparation for i18nNguyễn Thái Ngọc Duy, Jul 18, 2018
  10. Junio C HamanoJul 19, 2018
  11. Junio C HamanoJul 19, 2018
  12. Duy NguyenJul 21, 2018
  13. 04/23 builtin/config.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 18, 2018
  14. 05/23 builtin/grep.c: mark strings for translationNguyễn Thái Ngọc Duy, Jul 18, 2018
  15. 06/23 builtin/pack-objects.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 18, 2018
  16. Junio C HamanoJul 19, 2018
  17. 08/23 commit-graph.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 18, 2018
  18. 07/23 builtin/replace.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 18, 2018
  19. 09/23 config.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 18, 2018
  20. 10/23 connect.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 18, 2018
  21. Junio C HamanoJul 19, 2018
  22. 11/23 convert.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 18, 2018
  23. 13/23 environment.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 18, 2018
  24. 12/23 dir.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 18, 2018
  25. 14/23 exec-cmd.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 18, 2018
  26. 15/23 object.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 18, 2018
  27. 16/23 pkt-line.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 18, 2018
  28. 17/23 refs.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 18, 2018
  29. 18/23 refspec.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 18, 2018
  30. 19/23 replace-object.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 18, 2018
  31. 20/23 sequencer.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 18, 2018
  32. 21/23 sha1-file.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 18, 2018
  33. 22/23 transport.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 18, 2018
  34. 23/23 transport-helper.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 18, 2018
  35. 00/23 Mark more strings for translationNguyễn Thái Ngọc Duy, Jul 21, 2018
  36. 01/23 Update messages in preparation for i18nNguyễn Thái Ngọc Duy, Jul 21, 2018
  37. 05/23 builtin/grep.c: mark strings for translationNguyễn Thái Ngọc Duy, Jul 21, 2018
  38. 03/23 archive-zip.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 21, 2018
  39. 04/23 builtin/config.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 21, 2018
  40. 06/23 builtin/pack-objects.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 21, 2018
  41. 08/23 commit-graph.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 21, 2018
  42. 07/23 builtin/replace.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 21, 2018
  43. 10/23 connect.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 21, 2018
  44. 12/23 dir.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 21, 2018
  45. 13/23 environment.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 21, 2018
  46. 15/23 object.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 21, 2018
  47. 14/23 exec-cmd.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 21, 2018
  48. 11/23 convert.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 21, 2018
  49. 16/23 pkt-line.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 21, 2018
  50. 18/23 refspec.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 21, 2018
  51. 19/23 replace-object.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 21, 2018
  52. 20/23 sequencer.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 21, 2018
  53. 17/23 refs.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 21, 2018
  54. 21/23 sha1-file.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 21, 2018
  55. 22/23 transport.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 21, 2018
  56. 23/23 transport-helper.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 21, 2018
  57. 09/23 config.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 21, 2018
  58. 02/23 archive-tar.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jul 21, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.