From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 19 Jul 2018 18:26:02 GMT
Subject: Re: [PATCH v2 03/23] archive-zip.c: mark more strings for translation
Message-ID: <xmqqin5bf5fp.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180718161101.19765-4-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

> -		return error("path too long (%d chars, SHA1: %s): %s",
> +		return error(_("path too long (%d chars, SHA1: %s): %s"),
> -		return error("unsupported file mode: 0%o (SHA1: %s)", mode,
> +		return error(_("unsupported file mode: 0%o (SHA1: %s)"), mode,

The same #leftoverbits comment as 02/23 applies here.

> @@ -601,7 +601,7 @@ static void dos_time(timestamp_t *timestamp, int *dos_date, int *dos_time)
>  	struct tm *t;
>  
>  	if (date_overflows(*timestamp))
> -		die("timestamp too large for this system: %"PRItime,
> +		die(_("timestamp too large for this system: %"PRItime),
>  		    *timestamp);

I suspect that this won't do the right "cross-platform" thing.  For
built-in PRItype formats gettext tool knows about, *.po files let
translators translate original with "%<PRItype>" into localized text
with the same "%<PRItype>" left, and the runtime does the right
thing, but for a custom format like PRItime there is no such
support.