git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/1] t0001: fix on case-insensitive filesystems

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 24, 2019, 17:09 UTC
Message-ID
<xmqqimsuj4ft.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<nycvar.QRO.7.76.6.1906241212220.44@tvgsbejvaqbjf.bet>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 9 quoted lines
>> I wonder if we want (possibly local) test_cmp_fspath that can be
>> used more like
>>
>> 	test_cmp_fspath "$(pwd)/realgitdir" "$(sed -e "s/^gitdir: //" newdir/.git)"
>>
>> to compare two paths, honoring the case sensitivity of the
>> filesystem.
>
> I agree that that's a much better approach to fix the issue.

I find that response somewhat surprising :-|. In any case, I am not sure what kind of 'path' other than the filesystem one we would deal with in the context of Git and its test suite, so perhaps we should drop 'fs' from the name of the helper function if we were to go that route.

Previous: Johannes SchindelinNext: Johannes Schindelin
Message 12 of 18 in “Fix a test on NTFS (and probably HFS+)”
  1. 0/1 Fix a test on NTFS (and probably HFS+)Johannes Schindelin via GitGitGadget, Jun 8, 2019
  2. 1/1 t0001: fix on case-insensitive filesystemsJohannes Schindelin via GitGitGadget, Jun 8, 2019
  3. Martin ÅgrenJun 9, 2019
  4. Johannes SchindelinJun 19, 2019
  5. brian m. carlsonJun 9, 2019
  6. Junio C HamanoJun 10, 2019
  7. Johannes SchindelinJun 19, 2019
  8. Ævar Arnfjörð BjarmasonJun 21, 2019
  9. Johannes SchindelinJun 21, 2019
  10. Junio C HamanoJun 21, 2019
  11. Johannes SchindelinJun 24, 2019
  12. Junio C HamanoJun 24, 2019
  13. Johannes SchindelinJun 24, 2019
  14. Junio C HamanoJun 24, 2019
  15. Johannes SchindelinJun 24, 2019
  16. Junio C HamanoJun 24, 2019
  17. vger vs GitGitGadget, was Re: [PATCH v3 1/1] t0001: fix on case-insensitive filesystemsJohannes Schindelin, Jun 25, 2019
  18. Junio C HamanoJun 25, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.