git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/1] t0001: fix on case-insensitive filesystems

From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Date
Jun 8, 2019, 14:43 UTC
Message-ID
<1dd56d034efb6ff251bdac8d099052175f4777a0.1560005022.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.151.git.gitgitgadget@gmail.com>
From: Johannes Schindelin <johannes.schindelin@gmx.de>

On a case-insensitive filesystem, such as HFS+ or NTFS, it is possible that the idea Bash has of the current directory differs in case from what Git thinks it is. That's totally okay, though, and we should not expect otherwise.

Reported by Jameson Miller.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 t/t0001-init.sh | 12 ++++++++++++
 1 file changed, 12 insertions(+)
diff --git a/t/t0001-init.sh b/t/t0001-init.sh
index 42a263cada..f54a69e2d9 100755
--- a/t/t0001-init.sh
+++ b/t/t0001-init.sh
@@ -307,10 +307,20 @@ test_expect_success 'init prefers command line to GIT_DIR' '
 	test_path_is_missing otherdir/refs
 '
 
+downcase_on_case_insensitive_fs () {
+	test false = "$(git config --get core.filemode)" || return 0
+	for f
+	do
+		tr A-Z a-z <"$f" >"$f".downcased &&
+		mv -f "$f".downcased "$f" || return 1
+	done
+}
+
 test_expect_success 'init with separate gitdir' '
 	rm -rf newdir &&
 	git init --separate-git-dir realgitdir newdir &&
 	echo "gitdir: $(pwd)/realgitdir" >expected &&
+	downcase_on_case_insensitive_fs expected newdir/.git &&
 	test_cmp expected newdir/.git &&
 	test_path_is_dir realgitdir/refs
 '
@@ -365,6 +375,7 @@ test_expect_success 're-init to update git link' '
 	git init --separate-git-dir ../surrealgitdir
 	) &&
 	echo "gitdir: $(pwd)/surrealgitdir" >expected &&
+	downcase_on_case_insensitive_fs expected newdir/.git &&
 	test_cmp expected newdir/.git &&
 	test_path_is_dir surrealgitdir/refs &&
 	test_path_is_missing realgitdir/refs
@@ -378,6 +389,7 @@ test_expect_success 're-init to move gitdir' '
 	git init --separate-git-dir ../realgitdir
 	) &&
 	echo "gitdir: $(pwd)/realgitdir" >expected &&
+	downcase_on_case_insensitive_fs expected newdir/.git &&
 	test_cmp expected newdir/.git &&
 	test_path_is_dir realgitdir/refs
 '
-- 
gitgitgadget
Previous: Johannes Schindelin via GitGitGadgetNext: Martin Ågren
Message 2 of 18 in “Fix a test on NTFS (and probably HFS+)”
  1. 0/1 Fix a test on NTFS (and probably HFS+)Johannes Schindelin via GitGitGadget, Jun 8, 2019
  2. 1/1 t0001: fix on case-insensitive filesystemsJohannes Schindelin via GitGitGadget, Jun 8, 2019
  3. Martin ÅgrenJun 9, 2019
  4. Johannes SchindelinJun 19, 2019
  5. brian m. carlsonJun 9, 2019
  6. Junio C HamanoJun 10, 2019
  7. Johannes SchindelinJun 19, 2019
  8. Ævar Arnfjörð BjarmasonJun 21, 2019
  9. Johannes SchindelinJun 21, 2019
  10. Junio C HamanoJun 21, 2019
  11. Johannes SchindelinJun 24, 2019
  12. Junio C HamanoJun 24, 2019
  13. Johannes SchindelinJun 24, 2019
  14. Junio C HamanoJun 24, 2019
  15. Johannes SchindelinJun 24, 2019
  16. Junio C HamanoJun 24, 2019
  17. vger vs GitGitGadget, was Re: [PATCH v3 1/1] t0001: fix on case-insensitive filesystemsJohannes Schindelin, Jun 25, 2019
  18. Junio C HamanoJun 25, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.