Re: [RFC PATCH 1/7] Makefile: alphabetically sort += lists

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 17, 2019, 18:07 UTC
Message-ID: <xmqqimon6yar.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <02a16f9bdf740841d9a4be765e72b9fa5ae5d75c.1571246693.git.liu.denton@gmail.com>

Denton Liu <liu.denton@gmail.com> writes:

> There are many += lists in the Makefile and, over time, they have gotten
> slightly out of order, alphabetically. Alphabetically sort all += lists
> to bring them back in order.
> ...

Hmm.  I like the general thrust, but ...

Show 5 quoted lines

>  LIB_OBJS += combine-diff.o
> -LIB_OBJS += commit.o
>  LIB_OBJS += commit-graph.o
>  LIB_OBJS += commit-reach.o
> +LIB_OBJS += commit.o

... I do not particularly see this change (there may be similar ones) desirable. I'd find it it be much more natural to sort "commit-anything" after "commit", and that is true with or without the common extension ".o" added to these entries.

In short, flipping these entries because '.' sorts later than '-' is making the result look "less sorted", at least to me.

Thanks.