Re: [RFC PATCH 1/7] Makefile: alphabetically sort += lists
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Oct 21, 2019, 18:44 UTC
- Message-ID
- <nycvar.QRO.7.76.6.1910212043200.46@tvgsbejvaqbjf.bet>
- In-Reply-To
- <xmqqimon6yar.fsf@gitster-ct.c.googlers.com>
Hi Junio,
On Fri, 18 Oct 2019, Junio C Hamano wrote:
Show 22 quoted lines
> Denton Liu <liu.denton@gmail.com> writes: > > > There are many += lists in the Makefile and, over time, they have gotten > > slightly out of order, alphabetically. Alphabetically sort all += lists > > to bring them back in order. > > ... > > Hmm. I like the general thrust, but ... > > > LIB_OBJS += combine-diff.o > > -LIB_OBJS += commit.o > > LIB_OBJS += commit-graph.o > > LIB_OBJS += commit-reach.o > > +LIB_OBJS += commit.o > > ... I do not particularly see this change (there may be similar > ones) desirable. I'd find it it be much more natural to sort > "commit-anything" after "commit", and that is true with or without > the common extension ".o" added to these entries. > > In short, flipping these entries because '.' sorts later than '-' is > making the result look "less sorted", at least to me.
The problem with this argument is that it disagrees with ASCII, as `-` has code 0x2d while `.` has code 0x2e, i.e. it is lexicographically _larger_.
So Denton's patch does the correct thing.
Ciao, Dscho