Re: [PATCH 1/2] partial-clone: demonstrate bugs in partial fetch
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 19, 2020, 20:52 UTC
- Message-ID
- <xmqqimk2e1vl.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <dbc1bdcae16f8b9941add514264b0fe04cda48c0.1582129312.git.gitgitgadget@gmail.com>
"Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 18 quoted lines
> diff --git a/t/t5616-partial-clone.sh b/t/t5616-partial-clone.sh > index fea56cda6d3..ed2ef45c37a 100755 > --- a/t/t5616-partial-clone.sh > +++ b/t/t5616-partial-clone.sh > @@ -374,6 +374,32 @@ test_expect_success 'fetch lazy-fetches only to resolve deltas, protocol v2' ' > grep "want $(cat hash)" trace > ' > > +test_expect_failure 'verify fetch succeeds when asking for new tags' ' > + git clone --filter=blob:none "file://$(pwd)/srv.bare" tag-test && > + for i in I J K > + do > + test_commit -C src $i && > + git -C src branch $i > + done && > + git -C srv.bare fetch --tags origin +refs/heads/*:refs/heads/* && > + git -C tag-test fetch --tags origin > +'
Is this about an ultra-recent regresssion? When applied directly on top of v2.25.0, this one seems to pass already without any change.
Show 17 quoted lines
> +test_expect_failure 'verify fetch downloads only one pack when updating refs' ' > + git clone --filter=blob:none "file://$(pwd)/srv.bare" pack-test && > + ls pack-test/.git/objects/pack/*pack >pack-list && > + test_line_count = 2 pack-list && > + for i in A B C > + do > + test_commit -C src $i && > + git -C src branch $i > + done && > + git -C srv.bare fetch origin +refs/heads/*:refs/heads/* && > + git -C pack-test fetch origin && > + ls pack-test/.git/objects/pack/*pack >pack-list && > + test_line_count = 3 pack-list > +' > + > . "$TEST_DIRECTORY"/lib-httpd.sh > start_httpd