Re: [PATCH 1/2] partial-clone: demonstrate bugs in partial fetch
On 2/19/2020 1:38 PM, Eric Sunshine wrote:
Show 10 quoted lines
> On Wed, Feb 19, 2020 at 11:22 AM Derrick Stolee via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
>> [...]
>> The tests are ordered in this way because if I swap the test order the
>> tag test will succeed instead of fail. I believe this is because somehow
>> we need the srv.bare repo to not have any tags when we clone, but then
>> have tags in our next fetch.
>
> This ordering requirement might deserve an in-code comment in the test
> script itself.
Show 24 quoted lines
> More below...
>
>> Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
>> ---
>> diff --git a/t/t5616-partial-clone.sh b/t/t5616-partial-clone.sh
>> @@ -374,6 +374,32 @@ test_expect_success 'fetch lazy-fetches only to resolve deltas, protocol v2' '
>> +test_expect_failure 'verify fetch succeeds when asking for new tags' '
>> + git clone --filter=blob:none "file://$(pwd)/srv.bare" tag-test &&
>> + for i in I J K
>> + do
>> + test_commit -C src $i &&
>> + git -C src branch $i
>> + done &&
>
> If test_commit() or git-branch fail, those failures will go unnoticed.
> You can fix this by bailing from the loop, like this:
>
> for i in I J K
> do
> test_commit -C src $i &&
> git -C src branch $i || return 1
> done &&
>
> Same comment applies to the other new test.
Derrick Stolee <stolee@gmail.com>