Re: [PATCH v3 4/4] submodule: port submodule subcommand 'summary' from shell to C

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 21, 2020, 16:35 UTC
Message-ID: <xmqqimdc9cuc.fsf@gitster.c.googlers.com>
In-Reply-To: <nycvar.QRO.7.76.6.2008211708280.56@tvgsbejvaqbjf.bet>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 9 quoted lines

> Sadly, this breaks on Windows: on Linux (and before this patch, also on
> Windows), the error message reads somewhat like this:
>
> 	fatal: exec 'rev-parse': cd to 'my-subm' failed: No such file or directory
>
> However, with the built-in `git submodule summary`, on Windows the error
> message reads like this:
>
> 	error: cannot spawn git: No such file or directory

I think a test that relies on platform-specific error string is a bug. It's like expecting an exact string out of strerror(), which we had to fix a few times.

So I am not sure we would want to butcher compat/mingw.c only to match such an expectation by a (buggy) test.