Re: [PATCH v3 4/4] submodule: port submodule subcommand 'summary' from shell to C
- From
Shourya Shukla <shouryashukla.oo@gmail.com>
- Date
- Aug 21, 2020, 17:17 UTC
- Message-ID
- <20200821171705.GA16484@konoha>
- In-Reply-To
- <xmqqimdc9cuc.fsf@gitster.c.googlers.com>
> I think a test that relies on platform-specific error string is a > bug. It's like expecting an exact string out of strerror(), which > we had to fix a few times.
> So I am not sure we would want to butcher compat/mingw.c only to > match such an expectation by a (buggy) test.
Alright. That is understandable. What alternative do you suggest? Should we change the check in the test?