Re: [PATCH 1/2] pkt-line: add packet_fwrite

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 26, 2021, 16:33 UTC
Message-ID: <xmqqilzsf9nh.fsf@gitster.g>
In-Reply-To: <20210826100648.10333-1-jacob@gitlab.com>

Jacob Vosmaer <jacob@gitlab.com> writes:

Show 11 quoted lines

> This adds a new function packet_fwrite which works like packet_write,
> except it writes to a stdio stream.
>
> Helped-by: Patrick Steinhardt <ps@pks.im>
> Signed-off-by: Jacob Vosmaer <jacob@gitlab.com>
> ---
>  cache.h        |  1 +
>  pkt-line.c     | 16 ++++++++++++++++
>  pkt-line.h     |  1 +
>  write-or-die.c |  6 ++++++
>  4 files changed, 24 insertions(+)

I wonder if our readers are all proficient enough not to require some comment to warn them about the care that must be taken when packet_fwrite() and packet_write() are mixed together (i.e. stdio flushing, etc.), but other than that, this sounds quite straight-forward.