git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/2] send_ref buffering

From
Jacob Vosmaer <jacob@gitlab.com>
Date
Aug 31, 2021, 17:44 UTC
Message-ID
<CADMWQoOfPr47a6bJtApt=wSE9BrgXQKJRfJuNAj0zbtio2BRHw@mail.gmail.com>
In-Reply-To
<CADMWQoPerffQcTfKh3bfesjgHaBqXGzW2805knyRW3R_q4V-YA@mail.gmail.com>
On Tue, Aug 31, 2021 at 3:08 PM Jacob Vosmaer <jacob@gitlab.com> wrote:
Show 8 quoted lines
>
> On Tue, Aug 31, 2021 at 12:25 PM Jeff King <peff@peff.net> wrote:
> > I do think it would be nice to take the packet_writer
> > interface further (letting it replace the static buf, and use stdio
> > handles, and using it throughout upload-pack).
> I would like that too, for the sake of neatness and general
> performance, but I don't have the time to take on a larger project
> like that at the moment.

I gave solving the problem with packet_writer a couple of hours today. The diff gets too big, and I have too little confidence I'm not introducing deadlocks. This really is more work than I can chew off right now. Sorry!

Jacob
Previous: Jacob VosmaerNext: Jeff King
Message 24 of 27 in “upload-pack: buffer ref advertisement writes”
  1. 1/1 upload-pack: buffer ref advertisement writesJacob Vosmaer, Aug 24, 2021
  2. Taylor BlauAug 24, 2021
  3. Junio C HamanoAug 24, 2021
  4. Jeff KingAug 25, 2021
  5. Jacob VosmaerAug 26, 2021
  6. 1/2 pkt-line: add packet_fwriteJacob Vosmaer, Aug 26, 2021
  7. 2/2 upload-pack: use stdio in send_ref callbacksJacob Vosmaer, Aug 26, 2021
  8. Junio C HamanoAug 26, 2021
  9. Junio C HamanoAug 26, 2021
  10. Taylor BlauAug 26, 2021
  11. Jeff KingAug 26, 2021
  12. Junio C HamanoAug 27, 2021
  13. 0/2 send_ref bufferingJacob Vosmaer, Aug 31, 2021
  14. 1/2 pkt-line: add stdio packet write functionsJacob Vosmaer, Aug 31, 2021
  15. Jeff KingAug 31, 2021
  16. Junio C HamanoAug 31, 2021
  17. 0/2 send_ref bufferingJacob Vosmaer, Sep 1, 2021
  18. 2/2 upload-pack: use stdio in send_ref callbacksJacob Vosmaer, Sep 1, 2021
  19. 1/2 pkt-line: add stdio packet write functionsJacob Vosmaer, Sep 1, 2021
  20. Jeff KingSep 2, 2021
  21. 2/2 upload-pack: use stdio in send_ref callbacksJacob Vosmaer, Aug 31, 2021
  22. Jeff KingAug 31, 2021
  23. Jacob VosmaerAug 31, 2021
  24. Jacob VosmaerAug 31, 2021
  25. Jeff KingSep 1, 2021
  26. Jeff KingAug 26, 2021
  27. Junio C HamanoAug 26, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.