Re: [PATCH] refs/files-backend: remove unused open mode parameter
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 13, 2021, 18:22 UTC
- Message-ID
- <xmqqilz4fi86.fsf@gitster.g>
- In-Reply-To
- <CAFQ2z_NAXsOzbWujpm=jGxODJi+xsC9iFYd-W+dTqn9j5DybjQ@mail.gmail.com>
Han-Wen Nienhuys <hanwen@google.com> writes:
Show 7 quoted lines
> On Thu, Sep 9, 2021 at 11:46 PM René Scharfe <l.s.r@web.de> wrote: >> >> We only need to provide a mode if we are willing to let open(2) create >> the file, which is not the case here, so drop the unnecessary parameter. > > I was #today years old when I learned that C supports (a limited form > of) function signature overloading.
I do not think it is that kind of magic.
Like printf(3) that allows its early parameter to affect the way how its later parameters are recognised, it just allows the flags word to decide if it needs to grab one extra mode_t out of va_list or not, which can be done as a plain vanilla varargs function, i.e.
extern int open(const char *path, int flags, ...);