git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] refs/files-backend: remove unused open mode parameter

From
Han-Wen Nienhuys <hanwen@google.com>
Date
Sep 13, 2021, 10:12 UTC
Message-ID
<CAFQ2z_NAXsOzbWujpm=jGxODJi+xsC9iFYd-W+dTqn9j5DybjQ@mail.gmail.com>
In-Reply-To
<ea424e3d-6269-f50d-1a4a-643bb95cfa12@web.de>
On Thu, Sep 9, 2021 at 11:46 PM René Scharfe <l.s.r@web.de> wrote:
>
> We only need to provide a mode if we are willing to let open(2) create
> the file, which is not the case here, so drop the unnecessary parameter.

I was #today years old when I learned that C supports (a limited form of) function signature overloading.

LGTM
-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--
Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 5 in “refs/files-backend: remove unused open mode parameter”
  1. refs/files-backend: remove unused open mode parameterRené Scharfe, Sep 9, 2021
  2. Junio C HamanoSep 10, 2021
  3. Han-Wen NienhuysSep 13, 2021
  4. Junio C HamanoSep 13, 2021
  5. Jeff KingSep 13, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.