git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] negotiator/skipping: avoid stack overflow

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 25, 2022, 23:52 UTC
Message-ID
<xmqqilk7mpg8.fsf@gitster.g>
In-Reply-To
<20221025232934.1504445-1-jonathantanmy@google.com>
Jonathan Tan <jonathantanmy@google.com> writes:
> mark_common() in negotiator/skipping.c may overflow the stack due to
> recursive function calls. Avoid this by instead recursing using a
> heap-allocated data structure.

Very straight-forward. I think we've done quite a many of these in various places by now ;-)

Previous: Jonathan Tan
Message 2 of 2 in “negotiator/skipping: avoid stack overflow”
  1. negotiator/skipping: avoid stack overflowJonathan Tan, Oct 25, 2022
  2. Junio C HamanoOct 25, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.