From: Junio C Hamano Date: Tue, 25 Oct 2022 23:52:07 GMT Subject: Re: [PATCH] negotiator/skipping: avoid stack overflow Message-ID: In-Reply-To: <20221025232934.1504445-1-jonathantanmy@google.com> Jonathan Tan writes: > mark_common() in negotiator/skipping.c may overflow the stack due to > recursive function calls. Avoid this by instead recursing using a > heap-allocated data structure. Very straight-forward. I think we've done quite a many of these in various places by now ;-)