git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/1] config: add back code comment

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 29, 2024, 18:28 UTC
Message-ID
<xmqqil3chu4f.fsf@gitster.g>
In-Reply-To
<ZbeMw5tgY9S6k6y6@tanuki>
Patrick Steinhardt <ps@pks.im> writes:
Show 12 quoted lines
>>  		if (!given_config_source.file)
>> +			/*
>> +			 * It is unknown if HOME/.gitconfig exists, so
>> +			 * we do not know if we should write to XDG
>> +			 * location; error out even if XDG_CONFIG_HOME
>> +			 * is set and points at a sane location.
>> +			 */
>>  			die(_("$HOME not set"));
>>  		given_config_source.scope = CONFIG_SCOPE_GLOBAL;
>>  	} else if (use_system_config) {
>
> Thanks for adding the comment back in! The patch looks good to me.
Yeah, thanks, both.
Previous: Patrick SteinhardtNext: Kristoffer Haugsbakk
Message 4 of 6 in “config: add back code comment”
  1. 0/1 config: add back code commentKristoffer Haugsbakk, Jan 28, 2024
  2. 1/1 config: add back code commentKristoffer Haugsbakk, Jan 28, 2024
  3. Patrick SteinhardtJan 29, 2024
  4. Junio C HamanoJan 29, 2024
  5. 0/1 config: add back code commentKristoffer Haugsbakk, Jan 29, 2024
  6. 1/1 config: add back code commentKristoffer Haugsbakk, Jan 29, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.