git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/1] config: add back code comment

From
Patrick Steinhardt <ps@pks.im>
Date
Jan 29, 2024, 11:32 UTC
Message-ID
<ZbeMw5tgY9S6k6y6@tanuki>
In-Reply-To
<48d66e94ece3b763acbe933561d82157c02a5f58.1706466321.git.code@khaugsbakk.name>
On Sun, Jan 28, 2024 at 07:31:40PM +0100, Kristoffer Haugsbakk wrote:
Show 27 quoted lines
> c15129b699 (config: factor out global config file retrieval, 2024-01-18)
> was a refactor that moved some of the code in this function to
> `config.c`. However, in the process I managed to drop this code comment
> which explains `$HOME not set`.
> 
> Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>
> ---
>  builtin/config.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/builtin/config.c b/builtin/config.c
> index 08fe36d499..b55bfae7d6 100644
> --- a/builtin/config.c
> +++ b/builtin/config.c
> @@ -710,6 +710,12 @@ int cmd_config(int argc, const char **argv, const char *prefix)
>  	if (use_global_config) {
>  		given_config_source.file = git_global_config();
>  		if (!given_config_source.file)
> +			/*
> +			 * It is unknown if HOME/.gitconfig exists, so
> +			 * we do not know if we should write to XDG
> +			 * location; error out even if XDG_CONFIG_HOME
> +			 * is set and points at a sane location.
> +			 */
>  			die(_("$HOME not set"));
>  		given_config_source.scope = CONFIG_SCOPE_GLOBAL;
>  	} else if (use_system_config) {
Thanks for adding the comment back in! The patch looks good to me.
Patrick
Previous: Kristoffer HaugsbakkNext: Junio C Hamano
Message 3 of 6 in “config: add back code comment”
  1. 0/1 config: add back code commentKristoffer Haugsbakk, Jan 28, 2024
  2. 1/1 config: add back code commentKristoffer Haugsbakk, Jan 28, 2024
  3. Patrick SteinhardtJan 29, 2024
  4. Junio C HamanoJan 29, 2024
  5. 0/1 config: add back code commentKristoffer Haugsbakk, Jan 29, 2024
  6. 1/1 config: add back code commentKristoffer Haugsbakk, Jan 29, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.