Re: [PATCH 0/2] refs: introduce reftable backend

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 30, 2024, 22:08 UTC
Message-ID: <xmqqil3aa30a.fsf@gitster.g>
In-Reply-To: <cover.1706601199.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> Patrick Steinhardt (2):
>   refs: introduce reftable backend
>   ci: add jobs to test with the reftable backend

I haven't checked the code in refs/reftable-backend.c at all, but judging from the fallout to other files, it issurprisingly cleanly done. I somehow expected that we would need more changes like exposing the helper function to compute shared permission bits, but I see that it was the only change needed. Everything else done to other files are natural requirement to plug the new thing as a new ref backend to the system. Very nicely done.

Thanks.

Show 21 quoted lines

>  .github/workflows/main.yml                    |    9 +
>  .gitlab-ci.yml                                |    9 +
>  Documentation/ref-storage-format.txt          |    2 +
>  .../technical/repository-version.txt          |    5 +-
>  Makefile                                      |    1 +
>  ci/lib.sh                                     |    2 +-
>  ci/run-build-and-tests.sh                     |    3 +
>  contrib/workdir/git-new-workdir               |    2 +-
>  path.c                                        |    2 +-
>  path.h                                        |    1 +
>  refs.c                                        |    1 +
>  refs/refs-internal.h                          |    1 +
>  refs/reftable-backend.c                       | 2286 +++++++++++++++++
>  repository.h                                  |    5 +-
>  t/t0610-reftable-basics.sh                    |  887 +++++++
>  t/t0611-reftable-httpd.sh                     |   26 +
>  t/test-lib.sh                                 |    2 +
>  17 files changed, 3237 insertions(+), 7 deletions(-)
>  create mode 100644 refs/reftable-backend.c
>  create mode 100755 t/t0610-reftable-basics.sh
>  create mode 100755 t/t0611-reftable-httpd.sh