Re: [PATCH 3/3] color: add support for 12-bit RGB colors

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 30, 2024, 18:41 UTC
Message-ID: <xmqqikzyzoam.fsf@gitster.g>
In-Reply-To: <xmqqmspazrj3.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 17 quoted lines

>>> @@ -146,7 +146,10 @@ test_expect_success 'non-hex character in RGB color' '
>>>  	invalid_color "#12x456" &&
>>>  	invalid_color "#123x56" &&
>>>  	invalid_color "#1234x6" &&
>>> -	invalid_color "#12345x"
>>> +	invalid_color "#12345x" &&
>>> +	invalid_color "#x23" &&
>>> +	invalid_color "#1x3" &&
>>> +	invalid_color "#12x"
>>>  '
>>
>> This made me wonder what we'd do with "#1", "#12", "#1234", etc. Looking
>> at the code change, I think we'd continue to reject them. I wonder if it
>> is worth covering here.
>
> Worth covering in this test, yes, but I am perfectly OK with leaving
> it outside the series as a #leftoverbit clean-up.

Ah, I take it back. The preimage was added by [2/3] so it is fair to say that that step would be the right place to do that from the get-go.