git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] color: add support for 12-bit RGB colors

From
Beat Bolli <dev+git@drbeat.li>
Date
Apr 29, 2024, 17:42 UTC
Message-ID
<d2d5bbfc-d2bb-4112-a12d-f19950125cb5@drbeat.li>
In-Reply-To
<xmqqo79sulqh.fsf@gitster.g>
On 29.04.2024 19:23, Junio C Hamano wrote:
Show 17 quoted lines
> "Beat Bolli" <bb@drbeat.li> writes:
> 
>> diff --git a/color.h b/color.h
>> index bb28343be210..7ed259a35bb4 100644
>> --- a/color.h
>> +++ b/color.h
>> @@ -112,7 +112,8 @@ int want_color_fd(int fd, int var);
>>    * Translate a Git color from 'value' into a string that the terminal can
>>    * interpret and store it into 'dst'. The Git color values are of the form
>>    * "foreground [background] [attr]" where fore- and background can be a color
>> - * name ("red"), a RGB code (#0xFF0000) or a 256-color-mode from the terminal.
>> + * name ("red"), a RGB code (#FF0000 or #F00) or a 256-color-mode from the
>> + * terminal.
>>    */
> 
> Good.  Hopefully we do not have such extra 0x in our end-user facing
> documentation?

No, this was the only '#0x' I found. config.txt is fine as per the first hunk.

Previous: Junio C HamanoNext: Jeff King
Message 7 of 13 in “color: add support for 12-bit RGB colors”
  1. 0/3 color: add support for 12-bit RGB colorsBeat Bolli, Apr 29, 2024
  2. 1/3 t/t4026-color: remove an extra double quote characterBeat Bolli, Apr 29, 2024
  3. Jeff KingApr 30, 2024
  4. 2/3 t/t4026-color: add test coverage for invalid RGB colorsBeat Bolli, Apr 29, 2024
  5. 3/3 color: add support for 12-bit RGB colorsBeat Bolli, Apr 29, 2024
  6. Junio C HamanoApr 29, 2024
  7. Beat BolliApr 29, 2024
  8. Jeff KingApr 30, 2024
  9. Junio C HamanoApr 30, 2024
  10. Junio C HamanoApr 30, 2024
  11. Junio C HamanoApr 30, 2024
  12. Jeff KingMay 3, 2024
  13. Taylor BlauApr 29, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.