Re: [PATCH 3/3] color: add support for 12-bit RGB colors
- From
Beat Bolli <dev+git@drbeat.li>
- Date
- Apr 29, 2024, 17:42 UTC
- Message-ID
- <d2d5bbfc-d2bb-4112-a12d-f19950125cb5@drbeat.li>
- In-Reply-To
- <xmqqo79sulqh.fsf@gitster.g>
On 29.04.2024 19:23, Junio C Hamano wrote:
Show 17 quoted lines
> "Beat Bolli" <bb@drbeat.li> writes:
>
>> diff --git a/color.h b/color.h
>> index bb28343be210..7ed259a35bb4 100644
>> --- a/color.h
>> +++ b/color.h
>> @@ -112,7 +112,8 @@ int want_color_fd(int fd, int var);
>> * Translate a Git color from 'value' into a string that the terminal can
>> * interpret and store it into 'dst'. The Git color values are of the form
>> * "foreground [background] [attr]" where fore- and background can be a color
>> - * name ("red"), a RGB code (#0xFF0000) or a 256-color-mode from the terminal.
>> + * name ("red"), a RGB code (#FF0000 or #F00) or a 256-color-mode from the
>> + * terminal.
>> */
>
> Good. Hopefully we do not have such extra 0x in our end-user facing
> documentation?No, this was the only '#0x' I found. config.txt is fine as per the first hunk.