git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] alternate approach to fixing fsmonitor hangs

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 11, 2024, 18:01 UTC
Message-ID
<xmqqiktyecyf.fsf@gitster.g>
In-Reply-To
<20241011090051.GA563709@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 16 quoted lines
> On Wed, Oct 09, 2024 at 01:03:14AM +0900, Koji Nakamaru wrote:
>
>> > But I've cleaned it up for presentation here, so at least we can look at
>> > the final form of both and see which we prefer.
>> 
>> Thank you for the new patch. It prevents to start accepting requests
>> until starting fs event listening and simplifies the code flow. It also
>> has sufficient comments, so later everyone can easily understand how it
>> works. I also tested it both on mac and windows and it works correctly.
>> 
>> I think this one should be adopted :)
>
> Thanks for reviewing, and for all your work identifying the problem in
> the first place! Looks like Junio has picked up my patch and it's
> already in 'next', so hopefully these 6-hour CI timeouts will soon be a
> thing of the past. :)
Yup.  Thanks, both of you.
Previous: Jeff King
Message 10 of 10 in “fsmonitor: fix hangs by delayed fs event listening”
  1. fsmonitor: fix hangs by delayed fs event listeningKoji Nakamaru via GitGitGadget, Oct 2, 2024
  2. Jeff KingOct 7, 2024
  3. Jeff KingOct 7, 2024
  4. Koji NakamaruOct 7, 2024
  5. 0/2 alternate approach to fixing fsmonitor hangsJeff King, Oct 8, 2024
  6. 1/2 simple-ipc: split async server initialization and runningJeff King, Oct 8, 2024
  7. 2/2 fsmonitor: initialize fs event listener before accepting clientsJeff King, Oct 8, 2024
  8. Koji NakamaruOct 8, 2024
  9. Jeff KingOct 11, 2024
  10. Junio C HamanoOct 11, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.