Re: [PATCH 0/2] alternate approach to fixing fsmonitor hangs

From: Koji Nakamaru <koji.nakamaru@gree.net>
Date: Oct 8, 2024, 16:03 UTC
Message-ID: <CAOTNsDyxmRZ155vV-Jh=1obMnR+F4ExY9B136fiGk0Vd23-zrw@mail.gmail.com>
In-Reply-To: <20241008083121.GA676391@coredump.intra.peff.net>

On Tue, Oct 8, 2024 at 5:31 PM Jeff King <peff@peff.net> wrote:

Show 8 quoted lines

> I've added in the necessary Windows bits, along with smoothing a few
> rough edges. Especially with the extra Windows changes (which I mostly
> had to guess-and-check by pushing to CI), I'm beginning to wonder if my
> solution isn't getting a bit too complicated, and maybe yours was the
> right way after all.
>
> But I've cleaned it up for presentation here, so at least we can look at
> the final form of both and see which we prefer.

Thank you for the new patch. It prevents to start accepting requests until starting fs event listening and simplifies the code flow. It also has sufficient comments, so later everyone can easily understand how it works. I also tested it both on mac and windows and it works correctly.

I think this one should be adopted :)

Koji Nakamaru