Re: [PATCH v3 0/4] Build improvements for clar

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 20, 2024, 01:24 UTC
Message-ID: <xmqqiksiae9w.fsf@gitster.g>
In-Reply-To: <7jdpmcwlxtyzqrqmcftcdmrw3tqopawtuuzqf3uaff2gklaxba@covcdisniubk>

Justin Tobler <jltobler@gmail.com> writes:

Show 28 quoted lines

> On 24/11/15 08:32AM, Patrick Steinhardt wrote:
>> Hi,
>> 
>> Dscho has reported in [1] that the CMake build instructions for clar do
>> not work well on Windows/MSVC because we execute the shell scripts
>> directly instead of using the discovered `SH_EXE`. This small patch
>> series fixes the issue.
>> 
>> Changes in v2:
>> 
>>     - Wrap overly long lines in the CMake build instructions.
>>     - Add the VERBATIM option.
>> 
>> Changes in v3:
>> 
>>     - Fix missing word.
>> 
>> Link to v1: https://lore.kernel.org/r/20241108-pks-clar-build-improvements-v1-0-25c1fe65ce37@pks.im
>> Link to v2: https://lore.kernel.org/r/20241111-pks-clar-build-improvements-v2-0-d4794d8d1b30@pks.im
>> 
>> Thanks!
>> 
>> Patrick
>
> I've reviewed this series and overall this version looks good to me.
> Embedding the awk script in the shell script and changing how the
> scripts get executed to address platform related build issues seems
> sensable to me.

Thanks, both.  Let's merge it down to 'next'.