git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 0/4] Build improvements for clar

From
Patrick Steinhardt <ps@pks.im>
Date
Nov 15, 2024, 07:32 UTC
Message-ID
<20241115-pks-clar-build-improvements-v3-0-29672bf65ec6@pks.im>
In-Reply-To
<20241108-pks-clar-build-improvements-v1-0-25c1fe65ce37@pks.im>
Hi,

Dscho has reported in [1] that the CMake build instructions for clar do not work well on Windows/MSVC because we execute the shell scripts directly instead of using the discovered `SH_EXE`. This small patch series fixes the issue.

Changes in v2:
    - Wrap overly long lines in the CMake build instructions.
    - Add the VERBATIM option.
Changes in v3:
    - Fix missing word.

Link to v1: https://lore.kernel.org/r/20241108-pks-clar-build-improvements-v1-0-25c1fe65ce37@pks.im Link to v2: https://lore.kernel.org/r/20241111-pks-clar-build-improvements-v2-0-d4794d8d1b30@pks.im

Thanks!
Patrick
[1]: <3b2cb360-297a-915c-ae27-c45f38fa49b9@gmx.de>
To: git@vger.kernel.org
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Phillip Wood <phillip.wood123@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>
Patrick Steinhardt (4):
      t/unit-tests: convert "clar-generate.awk" into a shell script
      cmake: use SH_EXE to execute clar scripts
      cmake: use verbatim arguments when invoking clar commands
      Makefile: let clar header targets depend on their scripts
 Makefile                             |  6 ++--
 contrib/buildsystems/CMakeLists.txt  | 16 ++++++---
 t/unit-tests/clar-generate.awk       | 50 ----------------------------
 t/unit-tests/generate-clar-suites.sh | 63 ++++++++++++++++++++++++++++++++++++
 4 files changed, 78 insertions(+), 57 deletions(-)
Range-diff versus v2:
1:  90d2402c5a ! 1:  dc713c236b t/unit-tests: convert "clar-generate.awk" into a shell script
    @@ Commit message
         may otherwise be a problem with build systems on platforms that use a
         different shell.
     
    -    While at it, wrap the overly lines in the CMake build instructions.
    +    While at it, wrap the overly long lines in the CMake build instructions.
     
         Signed-off-by: Patrick Steinhardt <ps@pks.im>
     
2:  cf298664d8 = 2:  19d292cc5c cmake: use SH_EXE to execute clar scripts
3:  ff557f8985 = 3:  52f5090a76 cmake: use verbatim arguments when invoking clar commands
4:  c634e2a6d4 = 4:  35117454d4 Makefile: let clar header targets depend on their scripts

--- base-commit: facbe4f633e4ad31e641f64617bc88074c659959 change-id: 20241108-pks-clar-build-improvements-1c3962a9a79f

Previous: Phillip WoodNext: Patrick Steinhardt
Message 19 of 27 in “Build improvements for clar”
  1. 0/3 Build improvements for clarPatrick Steinhardt, Nov 8, 2024
  2. 1/3 t/unit-tests: convert "clar-generate.awk" into a shell scriptPatrick Steinhardt, Nov 8, 2024
  3. 2/3 cmake: use SH_EXE to execute clar scriptsPatrick Steinhardt, Nov 8, 2024
  4. 3/3 Makefile: let clar header targets depend on their scriptsPatrick Steinhardt, Nov 8, 2024
  5. Phillip WoodNov 10, 2024
  6. Junio C HamanoNov 11, 2024
  7. Patrick SteinhardtNov 11, 2024
  8. Junio C HamanoNov 11, 2024
  9. 0/4 Build improvements for clarPatrick Steinhardt, Nov 11, 2024
  10. 1/4 t/unit-tests: convert "clar-generate.awk" into a shell scriptPatrick Steinhardt, Nov 11, 2024
  11. Junio C HamanoNov 11, 2024
  12. Patrick SteinhardtNov 12, 2024
  13. 2/4 cmake: use SH_EXE to execute clar scriptsPatrick Steinhardt, Nov 11, 2024
  14. 3/4 cmake: use verbatim arguments when invoking clar commandsPatrick Steinhardt, Nov 11, 2024
  15. Johannes SchindelinNov 13, 2024
  16. Phillip WoodNov 14, 2024
  17. 4/4 Makefile: let clar header targets depend on their scriptsPatrick Steinhardt, Nov 11, 2024
  18. Phillip WoodNov 11, 2024
  19. 0/4 Build improvements for clarPatrick Steinhardt, Nov 15, 2024
  20. 2/4 cmake: use SH_EXE to execute clar scriptsPatrick Steinhardt, Nov 15, 2024
  21. Justin ToblerNov 18, 2024
  22. Patrick SteinhardtNov 19, 2024
  23. 1/4 t/unit-tests: convert "clar-generate.awk" into a shell scriptPatrick Steinhardt, Nov 15, 2024
  24. 3/4 cmake: use verbatim arguments when invoking clar commandsPatrick Steinhardt, Nov 15, 2024
  25. 4/4 Makefile: let clar header targets depend on their scriptsPatrick Steinhardt, Nov 15, 2024
  26. Justin ToblerNov 19, 2024
  27. Junio C HamanoNov 20, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.