git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 00/14] Stop using `the_repository` in some trivial cases

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 7, 2025, 21:15 UTC
Message-ID
<xmqqikqqqq9z.fsf@gitster.g>
In-Reply-To
<87r05ejpl3.fsf@iotcl.com>
Toon Claes <toon@iotcl.com> writes:
Show 20 quoted lines
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> I went through half of the patches a week ago, but got back to reading
>> through the series today.
>
> I've also been reading through the whole series today, and the changes
> are trivial and look good to me.
>
>> The approach here is to simply bubble up the usage of `the_repository`
>> to upper layers and use `the_repository` there. The alternative approach
>> would be to try and resolve the dependency on the upper layers and not
>> use `the_repository`. This approach seems much safer. The patches look
>> good to me.
>
> I took me a while to get into the mindset of taking this approach, but
> after chatting with Patrick I've changed my mind and agree with this
> approach. The goal of this series is to eliminate the use of
> `the_repository` in the mentioned subsystems. Simply bubbling up the use
> of that variable to the callers of those subsystems is very trivial and
> safe to do.

Yup. That way, the conversion would be bug-to-bug compatible, which is much better than a rewrite that improves some parts while by mistake breaks the existing code.

Thanks, all.  Let's mark it for 'next'.
Previous: Toon Claes
Message 26 of 26 in “Stop using `the_repository` in some trivial cases”
  1. 00/14 Stop using `the_repository` in some trivial casesPatrick Steinhardt, Dec 17, 2024
  2. 01/14 progress: stop using `the_repository`Patrick Steinhardt, Dec 17, 2024
  3. Karthik NayakDec 31, 2024
  4. Toon ClaesJan 6, 2025
  5. Patrick SteinhardtJan 7, 2025
  6. 02/14 pager: stop using `the_repository`Patrick Steinhardt, Dec 17, 2024
  7. shejialuoDec 17, 2024
  8. Karthik NayakDec 31, 2024
  9. 03/14 trace: stop using `the_repository`Patrick Steinhardt, Dec 17, 2024
  10. 04/14 serve: stop using `the_repository`Patrick Steinhardt, Dec 17, 2024
  11. 05/14 send-pack: stop using `the_repository`Patrick Steinhardt, Dec 17, 2024
  12. 06/14 server-info: stop using `the_repository`Patrick Steinhardt, Dec 17, 2024
  13. shejialuoDec 17, 2024
  14. 07/14 diagnose: stop using `the_repository`Patrick Steinhardt, Dec 17, 2024
  15. 08/14 mailinfo: stop using `the_repository`Patrick Steinhardt, Dec 17, 2024
  16. 09/14 credential: stop using `the_repository`Patrick Steinhardt, Dec 17, 2024
  17. 10/14 resolve-undo: stop using `the_repository`Patrick Steinhardt, Dec 17, 2024
  18. 11/14 tmp-objdir: stop using `the_repository`Patrick Steinhardt, Dec 17, 2024
  19. 12/14 add-interactive: stop using `the_repository`Patrick Steinhardt, Dec 17, 2024
  20. 13/14 graph: stop using `the_repository`Patrick Steinhardt, Dec 17, 2024
  21. 14/14 match-trees: stop using `the_repository`Patrick Steinhardt, Dec 17, 2024
  22. shejialuoDec 17, 2024
  23. Patrick SteinhardtDec 27, 2024
  24. Karthik NayakJan 7, 2025
  25. Toon ClaesJan 7, 2025
  26. Junio C HamanoJan 7, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.