Re: [PATCH 00/14] Stop using `the_repository` in some trivial cases

From: Karthik Nayak <karthik.188@gmail.com>
Date: Jan 7, 2025, 11:41 UTC
Message-ID: <CAOLa=ZTn2vfmS480G2wnaMehoK6+Z7EZ3Wx=ctaaPjBetOkbcA@mail.gmail.com>
In-Reply-To: <20241217-pks-use-the-repository-conversion-v1-0-0dba48bcc239@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 16 quoted lines

> Hi,
>
> this small patch series performs some refactorings to stop using
> `the_repository` in several subsystems. There wasn't really any
> criterium for which subsystems I picked, except that all of them have
> been trivial to convert.
>
> In this patch series I'm merely bubbling up `the_repository` one more
> layer even though some calling contexts already have a repository
> available. For the sake of triviality I decided not to handle these
> cases though and instead let a future patch series worry about them.
>
> This series is built on v2.48.0-rc0 with ps/build-sign-compare at
> e03d2a9ccb (t/helper: don't depend on implicit wraparound, 2024-12-06)
> merged into it. There's a single merge conflict with 'seen' that can be
> solved like this:

I went through half of the patches a week ago, but got back to reading through the series today.

The approach here is to simply bubble up the usage of `the_repository` to upper layers and use `the_repository` there. The alternative approach would be to try and resolve the dependency on the upper layers and not use `the_repository`. This approach seems much safer. The patches look good to me.

Thanks!