git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4] t2400: replace 'test -[efd]' with 'test_path_is_*'

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 17, 2025, 13:10 UTC
Message-ID
<xmqqikkuy0m7.fsf@gitster.g>
In-Reply-To
<20250617002939.24478-1-rodmichelassi@gmail.com>
Rodrigo Michelassi <rodmichelassi@gmail.com> writes:
Show 13 quoted lines
> 'test_path_is_file', 'test_path_is_dir' and 'test_file_is_missing'
> are test helpers used in Git's development, that emit useful
> diagnostic information when they detect a failing condition, while
> test -[efd] does not.
> Replace the basic shell commands 'test -f', 'test -d' and 'test -e',
> with this modern path checking approach.
>
> Co-authored-by: Isabella Caselli <icaselli@usp.br>
> Signed-off-by: Isabella Caselli <icaselli@usp.br>
> Signed-off-by: Rodrigo Michelassi <rodmichelassi@gmail.com>
> ---
>  t/t2400-worktree-add.sh | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
Looking good.  Will queue.
Thanks.
Previous: Rodrigo Michelassi
Message 2 of 2 in “t2400: replace 'test -[efd]' with 'test_path_is_*'”
  1. t2400: replace 'test -[efd]' with 'test_path_is_*'Rodrigo Michelassi, Jun 17, 2025
  2. Junio C HamanoJun 17, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.