From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 17 Jun 2025 13:10:56 GMT
Subject: Re: [PATCH v4] t2400: replace 'test -[efd]' with 'test_path_is_*'
Message-ID: <xmqqikkuy0m7.fsf@gitster.g>
In-Reply-To: <20250617002939.24478-1-rodmichelassi@gmail.com>

Rodrigo Michelassi <rodmichelassi@gmail.com> writes:

> 'test_path_is_file', 'test_path_is_dir' and 'test_file_is_missing'
> are test helpers used in Git's development, that emit useful
> diagnostic information when they detect a failing condition, while
> test -[efd] does not.
> Replace the basic shell commands 'test -f', 'test -d' and 'test -e',
> with this modern path checking approach.
>
> Co-authored-by: Isabella Caselli <icaselli@usp.br>
> Signed-off-by: Isabella Caselli <icaselli@usp.br>
> Signed-off-by: Rodrigo Michelassi <rodmichelassi@gmail.com>
> ---
>  t/t2400-worktree-add.sh | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)

Looking good.  Will queue.

Thanks.