git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] submodule absorbgitdirs tests: use test_* helper functions

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 27, 2026, 15:59 UTC
Message-ID
<xmqqik60o22y.fsf@gitster.g>
In-Reply-To
<akTKHfKPsP3-Rn31@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 24 quoted lines
> On Tue, Jun 30, 2026 at 11:00:28AM -0700, Junio C Hamano wrote:
>> "Bryan B. Lima" <bblima@usp.br> writes:
>> 
>> > Use modern helper functions from test-lib-functions.sh to provide nice error messages.
>> >
>> > Signed-off-by: Bryan B. Lima <bblima@usp.br>
>> > Co-authored-by: Gustavo S. Correa <gustavoscorrea@usp.br>
>> > Signed-off-by: Gustavo S. Correa <gustavoscorrea@usp.br>
>> > ---
>> >  t/t7412-submodule-absorbgitdirs.sh | 22 +++++++++++-----------
>> >  1 file changed, 11 insertions(+), 11 deletions(-)
>> 
>> Welcome to the Git development community.
>
> Welcome indeed!
>
>> It is rare, but it happens from time to time, that we see a patch by
>> somebody we haven't seen on this list, and the patch looks perfect.
>> Very delighted.
>
> Sorry to spoil it: the order of SOBs is incorrect. The patch is authored
> by Bryan, so that signoff needs to come last.
>
> The patch itself looks good though, thanks!

This discussion thread has been hanging for a while after we saw this message. To help a new participant, here are a few tips.

 * These discussions can be seen on mail archives.  On the primary
   archive, the message I am responding to appears here:
   https://lore.kernel.org/git/akTKHfKPsP3-Rn31@pks.im/
   For any discussion you are interested in, replace the URL path
   with the Message-Id of the message that is part of the
   discussion.  For example, after sending a patch, you use the
   message ID of the patch message you sent out and by visiting the
   page there, you see everything people said on your patch.
   https://lore.kernel.org/git/20260630020220.1559190-1-bblima@usp.br/
   Scroll down to see the "Thread overview".
 * When you receive a review response to help you polish your patch
   submission, you are expected to respond to it.  If the reviewer
   suggested an improvement, either you respond explaining why your
   original is better without the change suggested, or you respond
   thanking the reviewer for the suggestion and promise to submit an
   updated version that incorporates the suggested improvements, and
   then take your time to improve the patch and send a "reroll".
   For this patch, it would be numbered "v2".
   As we can see, neither option has occurred, and this discussion
   thread is keeping everybody waiting.
Thanks.
Previous: Patrick Steinhardt
Message 4 of 4 in “submodule absorbgitdirs tests: use test_* helper functions”
  1. submodule absorbgitdirs tests: use test_* helper functionsBryan B. Lima, Jun 30, 2026
  2. Junio C HamanoJun 30, 2026
  3. Patrick SteinhardtJul 1, 2026
  4. Junio C HamanoJul 27, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.