git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] submodule absorbgitdirs tests: use test_* helper functions

From
Patrick Steinhardt <ps@pks.im>
Date
Jul 1, 2026, 08:04 UTC
Message-ID
<akTKHfKPsP3-Rn31@pks.im>
In-Reply-To
<xmqqmrwbsybn.fsf@gitster.g>
On Tue, Jun 30, 2026 at 11:00:28AM -0700, Junio C Hamano wrote:
Show 12 quoted lines
> "Bryan B. Lima" <bblima@usp.br> writes:
> 
> > Use modern helper functions from test-lib-functions.sh to provide nice error messages.
> >
> > Signed-off-by: Bryan B. Lima <bblima@usp.br>
> > Co-authored-by: Gustavo S. Correa <gustavoscorrea@usp.br>
> > Signed-off-by: Gustavo S. Correa <gustavoscorrea@usp.br>
> > ---
> >  t/t7412-submodule-absorbgitdirs.sh | 22 +++++++++++-----------
> >  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> Welcome to the Git development community.
Welcome indeed!
> It is rare, but it happens from time to time, that we see a patch by
> somebody we haven't seen on this list, and the patch looks perfect.
> Very delighted.

Sorry to spoil it: the order of SOBs is incorrect. The patch is authored by Bryan, so that signoff needs to come last.

The patch itself looks good though, thanks!
Patrick
Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 4 in “submodule absorbgitdirs tests: use test_* helper functions”
  1. submodule absorbgitdirs tests: use test_* helper functionsBryan B. Lima, Jun 30, 2026
  2. Junio C HamanoJun 30, 2026
  3. Patrick SteinhardtJul 1, 2026
  4. Junio C HamanoJul 27, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.