git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH] index-pack: optionally allow duplicate objects

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 29, 2026, 01:41 UTC
Message-ID
<xmqqik5ybmi9.fsf@gitster.g>
In-Reply-To
<20260728042550.91133-2-friel@openai.com>
friel@openai.com writes:
> Signed-off-by: Friel <friel@openai.com>
> ---
> Applies on top of tb/pack-with-duplicates.

I am really reluctant to take us in this direction. The last time I had a deep discussion on this was with Shawn Pearce (so those who knew him can tell how long ago that was), and the essence of his suggestion was that allowing malformed or invalid packfiles is a slippery slope. They complicate everything, from delta cycle detection to ensuring that repository data stays healthy.

Changes that help us detect such a broken pack as early as possible and prevent it from entering your repository are very much welcome. Changes that accept such a broken pack as if nothing were wrong, not so much.

Thanks.
Previous: Taylor BlauNext: Taylor Blau
Message 3 of 8 in “index-pack: optionally allow duplicate objects”
  1. index-pack: optionally allow duplicate objectsfriel@openai.com, Jul 28, 2026
  2. Taylor BlauJul 28, 2026
  3. Junio C HamanoJul 29, 2026
  4. Taylor BlauJul 29, 2026
  5. Junio C HamanoJul 29, 2026
  6. friel@openai.comJul 29, 2026
  7. Taylor BlauJul 29, 2026
  8. Taylor BlauJul 29, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.