Re: [PATCH v3 08/12] mingw: rely on MSYS2's metadata instead of hard-coding it
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 9, 2026, 21:17 UTC
- Message-ID
- <xmqqik4ep1jp.fsf@gitster.g>
- In-Reply-To
- <7ac8168d-5b5f-fec2-ec91-ff72f7b6f1fa@gmx.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 27 quoted lines
> Hi Hannes, > > On Wed, 9 Sep 2026, Johannes Sixt wrote: > >> Am 09.09.26 um 21:17 schrieb Johannes Schindelin via GitGitGadget: >> > [...] >> > >> > Note: This keeps the same, hard-coded MSYSTEM platform support for CMake >> > as before, but drops it for Meson (because it is unclear how Meson could >> > do this in a more flexible manner). >> >> I think this paragraph is now stale and should be removed from this >> commit message. I don't know if it makes sense to insert in 12/12, though. > > D'oh, of course! It _was_ unclear to me how Meson could do this, but I > obviously found a way to support this _somewhat_. > >> > >> > Helped-by: Junio C Hamano <gitster@pobox.com> >> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> >> >> Except for this, this is looking good now. > > Yes, this should also have a `Helped-by: Johannes Sixt <j6t@kdbg.org>`. > > Junio, can you squash those changes before merging to `next`, or do you > want me to send another iteration before I go to bed?
Those changes meaning removal of the "Note:" paragraph from 08/12 or anything more elaborate?