Re: [PATCH v2 08/12] mingw: rely on MSYS2's metadata instead of hard-coding it
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 31, 2026, 18:59 UTC
- Message-ID
- <xmqqbjaiw1yh.fsf@gitster.g>
- In-Reply-To
- <4f4129df-681f-4e99-8b1f-8bb96e206a2d@kdbg.org>
Johannes Sixt <j6t@kdbg.org> writes:
Show 40 quoted lines
> Am 12.08.26 um 09:52 schrieb Johannes Schindelin via GitGitGadget: >> diff --git a/config.mak.uname b/config.mak.uname >> index 21f53e3f7e..3a90995587 100644 >> --- a/config.mak.uname >> +++ b/config.mak.uname >> @@ -465,14 +465,8 @@ ifeq ($(uname_S),Windows) >> GIT_VERSION := $(GIT_VERSION).MSVC >> pathsep = ; >> # Assume that this is built in Git for Windows' SDK >> - ifeq (MINGW32,$(MSYSTEM)) >> - prefix = /mingw32 >> - else >> - ifeq (CLANGARM64,$(MSYSTEM)) >> - prefix = /clangarm64 >> - else >> - prefix = /mingw64 >> - endif >> + ifneq (,$(MSYSTEM)) >> + prefix = $(MINGW_PREFIX) >> endif >> # Prepend MSVC 64-bit tool-chain to PATH. >> # >> @@ -755,6 +749,10 @@ ifeq ($(uname_S),MINGW) >> BASIC_LDFLAGS += -Wl,--dynamicbase >> endif >> ifneq (,$(MSYSTEM)) >> + ifeq ($(MINGW_PREFIX),$(filter-out /%,$(MINGW_PREFIX))) >> + # Override if empty or does not start with a slash >> + MINGW_PREFIX := /$(shell echo '$(MSYSTEM)' | tr A-Z a-z) >> + endif >> prefix = $(MINGW_PREFIX) >> HOST_CPU = $(patsubst %-w64-mingw32,%,$(MINGW_CHOST)) >> BASIC_LDFLAGS += -Wl,--pic-executable > > At this point, MINGW_PREFIX is only used to set prefix. > > Only in 12/12 is the variable (and ENSURE_MSYSTEM_IS_SET) used to drive > C code. Therefore, it seems that the following hunks concerning the > CMake and meson build systems do not belong in this patch, yet, but only > in 12/12.
Haven't heard anything on this topic for a few weeks. Can we conclude it anytime soon? I do not like too many topics that are almost there hanging around only because they miss the finishing touches.
Thanks.