Re: [PATCH] gitlab-ci: fix "check" jobs with large merge requests
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 19, 2026, 20:09 UTC
- Message-ID
- <xmqqik2x4fle.fsf@gitster.g>
- In-Reply-To
- <atW_BmTQhxFRLc0a@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 13 quoted lines
> I tend to ignore those myself: > > - "check-style" is not all that useful as we don't fully submit us to > clang-format's style, so whatever it generates is not authoritative > anyway. > > - "check-whitespace" was quite useless to me because it breaks rather > frequently. > > I still think that "check-style" _could_ be useful, but only if we fully > commit to clang-format. It would remove a whole class of nitpicks > and thus reduce the burden on both newcomers and reviewers. But that's a > discussion I don't really want to lead :)
Hmph, I haven't seen check-whitespace giving useless false positive myself. I tend to agree that check-style would not be useful as it came fairly late to the project after all the code have been written long ago.