git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitlab-ci: fix "check" jobs with large merge requests

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 19, 2026, 20:09 UTC
Message-ID
<xmqqik2x4fle.fsf@gitster.g>
In-Reply-To
<atW_BmTQhxFRLc0a@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 13 quoted lines
> I tend to ignore those myself:
>
>   - "check-style" is not all that useful as we don't fully submit us to
>     clang-format's style, so whatever it generates is not authoritative
>     anyway.
>
>   - "check-whitespace" was quite useless to me because it breaks rather
>     frequently.
>
> I still think that "check-style" _could_ be useful, but only if we fully
> commit to clang-format. It would remove a whole class of nitpicks
> and thus reduce the burden on both newcomers and reviewers. But that's a
> discussion I don't really want to lead :)

Hmph, I haven't seen check-whitespace giving useless false positive myself. I tend to agree that check-style would not be useful as it came fairly late to the project after all the code have been written long ago.

Previous: Karthik NayakNext: Patrick Steinhardt
Message 5 of 6 in “gitlab-ci: fix "check" jobs with large merge requests”
  1. gitlab-ci: fix "check" jobs with large merge requestsPatrick Steinhardt, Oct 16, 2026
  2. Junio C HamanoOct 16, 2026
  3. Patrick SteinhardtOct 19, 2026
  4. Karthik NayakOct 19, 2026
  5. Junio C HamanoOct 19, 2026
  6. Patrick SteinhardtOct 20, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.