Re: [PATCH] gitlab-ci: fix "check" jobs with large merge requests
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Oct 20, 2026, 05:58 UTC
- Message-ID
- <atcC-of1posEyjEH@pks.im>
- In-Reply-To
- <xmqqik2x4fle.fsf@gitster.g>
On Mon, Oct 19, 2026 at 01:09:49PM -0700, Junio C Hamano wrote:
Show 20 quoted lines
> Patrick Steinhardt <ps@pks.im> writes: > > > I tend to ignore those myself: > > > > - "check-style" is not all that useful as we don't fully submit us to > > clang-format's style, so whatever it generates is not authoritative > > anyway. > > > > - "check-whitespace" was quite useless to me because it breaks rather > > frequently. > > > > I still think that "check-style" _could_ be useful, but only if we fully > > commit to clang-format. It would remove a whole class of nitpicks > > and thus reduce the burden on both newcomers and reviewers. But that's a > > discussion I don't really want to lead :) > > Hmph, I haven't seen check-whitespace giving useless false positive > myself. I tend to agree that check-style would not be useful as it > came fairly late to the project after all the code have been written > long ago.
Yeah, maybe check-whitespace will become more useful then for GitLab CI, too, after this patch has landed. In its current form I started ignoring it because it was broken way too often because of the shallow clones.
Patrick