git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/3] completion: complete "unstuck" `git push --recurse-submodules`

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 22, 2014, 21:17 UTC
Message-ID
<xmqqha29f606.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20140722205730.GD26927@serenity.lan>
John Keeping <john@keeping.me.uk> writes:
> Makes sense.  I don't think I noted the order in the "$cur" case, I just
> put the new one in here so that they were sorted lexicographically.

Unless there is particular reason, consistently using lexicographic order in all related places is one good way to organize things, but doing so would involve flipping orders in the other case statement for this particular patch. In general, I prefer to see people add new things at the end, when there is no particular reason to do otherwise.

> Do you want me to re-roll with this change or can you replace the patch
> while applying?

I think I had to flip the third one to adjust to the change I suggested to this; the result will be on 'pu', so please double check when I push it out.

Thanks.
Previous: John KeepingNext: John Keeping
Message 16 of 18 in “completion: add missing terminator in case statement”
  1. 1/4 completion: add missing terminator in case statementJohn Keeping, Jul 19, 2014
  2. 2/4 completion: complete "unstuck" `git push --recurse-submodules`John Keeping, Jul 19, 2014
  3. Johannes SixtJul 19, 2014
  4. John KeepingJul 19, 2014
  5. 3/4 completion: add some missing options to `git push`John Keeping, Jul 19, 2014
  6. 4/4 completion: complete `git push --force-with-lease=`John Keeping, Jul 19, 2014
  7. Junio C HamanoJul 21, 2014
  8. Junio C HamanoJul 21, 2014
  9. John KeepingJul 22, 2014
  10. Junio C HamanoJul 22, 2014
  11. 1/3 completion: complete "unstuck" `git push --recurse-submodules`John Keeping, Jul 22, 2014
  12. 2/3 completion: add some missing options to `git push`John Keeping, Jul 22, 2014
  13. 3/3 completion: complete `git push --force-with-lease=`John Keeping, Jul 22, 2014
  14. Junio C HamanoJul 22, 2014
  15. John KeepingJul 22, 2014
  16. Junio C HamanoJul 22, 2014
  17. John KeepingJul 23, 2014
  18. Junio C HamanoJul 23, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.