Re: [PATCH 2/4] completion: complete "unstuck" `git push --recurse-submodules`

From: Johannes Sixt <j6t@kdbg.org>
Date: Jul 19, 2014, 11:37 UTC
Message-ID: <53CA5876.40007@kdbg.org>
In-Reply-To: <a3317a7692675483f60ee10ff98e1e95a3dc4b5a.1405763157.git.john@keeping.me.uk>

Am 19.07.2014 11:45, schrieb John Keeping:

Show 17 quoted lines

> Since the argument to `--recurse-submodules` is mandatory, it does not
> need to be stuck to the option with `=`.
> 
> Signed-off-by: John Keeping <john@keeping.me.uk>
> ---
>  contrib/completion/git-completion.bash | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index d0b2895..06211a6 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -1624,6 +1624,10 @@ __git_push_recurse_submodules="check on-demand"
>  _git_push ()
>  {
>  	case "$prev" in
> +	--recurse_submodules)

This would need a dash, not an underscore.

Show 7 quoted lines

> +		__gitcomp "$__git_push_recurse_submodules"
> +		return
> +		;;
>  	--repo)
>  		__gitcomp_nl "$(__git_remotes)"
>  		return
>