Re: [PATCH 2/2] update-server-info: create info/* with mode 0666

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 6, 2015, 18:47 UTC
Message-ID: <xmqqh9w3px0a.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20150106035048.GB20087@peff.net>

Jeff King <peff@peff.net> writes:

Show 9 quoted lines

> +test_expect_success POSIXPERM 'info/refs is readable in unshared repo' '
> +	rm -f .git/info/refs &&
> +	test_unconfig core.sharedrepository &&
> +	umask 002 &&
> +	git update-server-info &&
> +	echo "-rw-rw-r--" >expect &&
> +	modebits .git/info/refs >actual &&
> +	test_cmp expect actual
> +'

Hmm, the label and the test look somewhat out-of-sync. "readable as long as umask allows it" would be more in line with what the fix is about (i.e. I would expect a test with that title to pass even if I changed 'umask 002' to 'umask 007', but that is not what we want in this series).

>  test_expect_success POSIXPERM 'git reflog expire honors core.sharedRepository' '
>  	umask 077 &&
>  	git config core.sharedRepository group &&