git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v6 09/11] ref-filter: move code from 'for-each-ref'

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 8, 2015, 18:08 UTC
Message-ID
<xmqqh9qiax8l.fsf@gitster.dls.corp.google.com>
In-Reply-To
<5575CD35.4030705@gmail.com>
Karthik Nayak <karthik.188@gmail.com> writes:
Show 18 quoted lines
> On 06/08/2015 10:38 PM, Matthieu Moy wrote:
>> Karthik Nayak <karthik.188@gmail.com> writes:
>>
>> > --- a/builtin/for-each-ref.c
>> > +++ b/builtin/for-each-ref.c
>> > @@ -1129,7 +56,7 @@ int cmd_for_each_ref(int argc, const char
>> > **argv, const char *prefix)
>> >
>> >       memset(&ref_cbdata, 0, sizeof(ref_cbdata));
>> >       ref_cbdata.filter.name_patterns = argv;
>> > -    for_each_rawref(ref_filter_handler, &ref_cbdata);
>> > +    filter_refs(for_each_rawref, &ref_cbdata);
>>
>> This seems unrelated from the rest of the patch. And you haven't
>> introduced filter_refs yet!
>>
> That definitely is, this happened after fixing merges I suppose.
> Ignore it for now, I'll fix it.

I am not sure which one of two copies of 09/11 is being discussed, but I'll stop here for now. Most of the patches up to 08/11 looked sensible, if the renames were a bit too noisy.

Thanks.
Previous: Karthik NayakNext: Karthik Nayak
Message 14 of 24 in “create ref-filter from for-each-ref”
  1. 0/11 create ref-filter from for-each-refKarthik Nayak, Jun 6, 2015
  2. 01/11 for-each-ref: extract helper functions out of grab_single_ref()Karthik Nayak, Jun 6, 2015
  3. 02/11 for-each-ref: clean up codeKarthik Nayak, Jun 6, 2015
  4. 03/11 for-each-ref: rename 'refinfo' to 'ref_array_item'Karthik Nayak, Jun 6, 2015
  5. 04/11 for-each-ref: introduce new structures for better organisationKarthik Nayak, Jun 6, 2015
  6. 05/11 for-each-ref: introduce 'ref_array_clear()'Karthik Nayak, Jun 6, 2015
  7. 06/11 for-each-ref: rename some functions and make them publicKarthik Nayak, Jun 6, 2015
  8. 07/11 for-each-ref: rename variables called sort to sortingKarthik Nayak, Jun 6, 2015
  9. 08/11 ref-filter: add 'ref-filter.h'Karthik Nayak, Jun 6, 2015
  10. 09/11 ref-filter: move code from 'for-each-ref'Karthik Nayak, Jun 6, 2015
  11. 09/11 ref-filter: move code from 'for-each-ref'Karthik Nayak, Jun 7, 2015
  12. Matthieu MoyJun 8, 2015
  13. Karthik NayakJun 8, 2015
  14. Junio C HamanoJun 8, 2015
  15. 10/11 for-each-ref: introduce filter_refs()Karthik Nayak, Jun 6, 2015
  16. 10/11 for-each-ref: introduce filter_refs()Karthik Nayak, Jun 7, 2015
  17. Junio C HamanoJun 8, 2015
  18. Karthik NayakJun 8, 2015
  19. 11/11 ref-filter: make 'ref_array_item' use a FLEX_ARRAY for refnameKarthik Nayak, Jun 6, 2015
  20. Junio C HamanoJun 8, 2015
  21. Karthik NayakJun 8, 2015
  22. Karthik NayakJun 7, 2015
  23. Matthieu MoyJun 8, 2015
  24. Karthik NayakJun 8, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.