Re: [PATCH v8 0/7] git-p4: add support for large file systems

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 3, 2015, 17:17 UTC
Message-ID: <xmqqh9m73m7z.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAE5ih78tsDe-RAUOEjrGMBJU0sage37V1sL9QLPZhRQhb5GUCA@mail.gmail.com>

Luke Diamand <luke@diamand.org> writes:

Show 23 quoted lines

> On 26 September 2015 at 08:54,  <larsxschneider@gmail.com> wrote:
>> From: Lars Schneider <larsxschneider@gmail.com>
>>
>> diff to v7:
>> * fix commit message line length (thanks Junio)
>> * fix sync command for large file system support (thanks Luke!)
>> * add test case for sync command
>> * rename git-p4.pushLargeFiles to git-p4.largeFilePush for consistency with
>>   other git-p4.largeFile* configs
>> * fix relative path handling for clone operation which caused a crash in the
>>   disk space check and t9819 (thanks Luke!)
>> * use test_path_is_missing instead of !test_path_is_file (thanks Luke!)
>>
>> The patch is again based on maint (ee6ad5f) as patches v1-v6 before.
>
>
> All looks good to me, Ack.
>
> One tiny thing perhaps Junio could comment on: the git commit message
> for 75abe9fa5b39980de27dfc33dd5b4f4b5926f34c, "git-p4: add optional
> type specifier to gitConfig reader" uses what looks like UTF-8 encoded
> left and right quotes, rather than regular ASCII quotes ("). I don't
> know if that matters.

Yeah, I noticed them, too. In general, I'd prefer to avoid these pretty-quotes myself, as they typically do not add much information (unless nesting matters, which is usually not the case in the log message, or something) and the primary effect of them is to force us to step outside ASCII, which causes editors and pagers to misalign for some people.

But it is not too huge an issue that it is worth to go back and fix them, either.

Thanks.