git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v8 5/7] git-p4: check free space during streaming

From
larsxschneider@gmail.com <larsxschneider@gmail.com>
Date
Sep 26, 2015, 07:55 UTC
Message-ID
<1443254104-14966-6-git-send-email-larsxschneider@gmail.com>
In-Reply-To
<1443254104-14966-1-git-send-email-larsxschneider@gmail.com>
From: Lars Schneider <larsxschneider@gmail.com>

git-p4 will just halt if there is not enough disk space while streaming content from P4 to Git. Add a check to ensure at least 4 times (arbitrarily chosen) the size of a streamed file is available.

Signed-off-by: Lars Schneider <larsxschneider@gmail.com>
---
 git-p4.py | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
diff --git a/git-p4.py b/git-p4.py
index e7a7ea4..6b1e395 100755
--- a/git-p4.py
+++ b/git-p4.py
@@ -104,6 +104,16 @@ def chdir(path, is_client_path=False):
         path = os.getcwd()
     os.environ['PWD'] = path
 
+def calcDiskFree():
+    """Return free space in bytes on the disk of the given dirname."""
+    if platform.system() == 'Windows':
+        free_bytes = ctypes.c_ulonglong(0)
+        ctypes.windll.kernel32.GetDiskFreeSpaceExW(ctypes.c_wchar_p(os.getcwd()), None, None, ctypes.pointer(free_bytes))
+        return free_bytes.value
+    else:
+        st = os.statvfs(os.getcwd())
+        return st.f_bavail * st.f_frsize
+
 def die(msg):
     if verbose:
         raise Exception(msg)
@@ -2256,6 +2266,14 @@ class P4Sync(Command, P4UserMap):
             if marshalled["code"] == "error":
                 if "data" in marshalled:
                     err = marshalled["data"].rstrip()
+
+        if not err and 'fileSize' in self.stream_file:
+            required_bytes = int((4 * int(self.stream_file["fileSize"])) - calcDiskFree())
+            if required_bytes > 0:
+                err = 'Not enough space left on %s! Free at least %i MB.' % (
+                    os.getcwd(), required_bytes/1024/1024
+                )
+
         if err:
             f = None
             if self.stream_have_file_info:
-- 
2.5.1
Previous: larsxschneider@gmail.comNext: larsxschneider@gmail.com
Message 6 of 13 in “git-p4: add support for large file systems”
  1. 0/7 git-p4: add support for large file systemslarsxschneider@gmail.com, Sep 26, 2015
  2. 1/7 git-p4: add optional type specifier to gitConfig readerlarsxschneider@gmail.com, Sep 26, 2015
  3. 2/7 git-p4: add gitConfigInt readerlarsxschneider@gmail.com, Sep 26, 2015
  4. 3/7 git-p4: return an empty list if a list config has no valueslarsxschneider@gmail.com, Sep 26, 2015
  5. 4/7 git-p4: add file streaming progress in verbose modelarsxschneider@gmail.com, Sep 26, 2015
  6. 5/7 git-p4: check free space during streaminglarsxschneider@gmail.com, Sep 26, 2015
  7. 6/7 git-p4: add support for large file systemslarsxschneider@gmail.com, Sep 26, 2015
  8. 7/7 git-p4: add Git LFS backend for large file systemlarsxschneider@gmail.com, Sep 26, 2015
  9. Junio C HamanoSep 28, 2015
  10. Luke DiamandOct 3, 2015
  11. Junio C HamanoOct 3, 2015
  12. Junio C HamanoOct 3, 2015
  13. Lars SchneiderOct 4, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.