Re: [PATCH v1 0/2] git-p4: kill watchdog and suppress irrelevant output

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 21, 2015, 20:31 UTC
Message-ID: <xmqqh9jbfsra.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1450629869-49522-1-git-send-email-larsxschneider@gmail.com>

larsxschneider@gmail.com writes:

Show 6 quoted lines

> From: Lars Schneider <larsxschneider@gmail.com>
>
> Hi,
>
> these patches extend "git-p4: add trap to kill p4d on test exit" (dfe90e8)
> and therefore should be applied on master.

Wait, wait. Please be a bit more careful when you use such a phrasing. Did somebody review these and said that these are trivially correct improvements?

This depends on what you exactly meant "extend" and "improve" (for the other one); if the "improvement" were to make something that used to be unusable to usable, then the more sensible way forward during the -rc stabilization period might be to revert the earlier merges to 'master' that brought in undercooked topic.

Thanks.

Show 13 quoted lines

>
> Thanks,
> Lars
>
> Lars Schneider (2):
>   git-p4: kill p4d watchdog on cleanup
>   git-p4: suppress non test relevant output
>
>  t/lib-git-p4.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> --
> 2.5.1