Re: [PATCH v1 0/2] git-p4: kill watchdog and suppress irrelevant output

From: Lars Schneider <larsxschneider@gmail.com>
Date: Dec 22, 2015, 09:12 UTC
Message-ID: <F3AA0745-A9C1-40D4-AF63-EDBFB7A5DB19@gmail.com>
In-Reply-To: <xmqqh9jbfsra.fsf@gitster.mtv.corp.google.com>

On 21 Dec 2015, at 21:31, Junio C Hamano <gitster@pobox.com> wrote:

Show 18 quoted lines

> larsxschneider@gmail.com writes:
> 
>> From: Lars Schneider <larsxschneider@gmail.com>
>> 
>> Hi,
>> 
>> these patches extend "git-p4: add trap to kill p4d on test exit" (dfe90e8)
>> and therefore should be applied on master.
> 
> Wait, wait.  Please be a bit more careful when you use such a
> phrasing.  Did somebody review these and said that these are
> trivially correct improvements?
> 
> This depends on what you exactly meant "extend" and "improve" (for
> the other one); if the "improvement" were to make something that
> used to be unusable to usable, then the more sensible way forward
> during the -rc stabilization period might be to revert the earlier
> merges to 'master' that brought in undercooked topic.

Oh. Thanks or making me aware of the inappropriate phrases! Nobody reviewed these patches, yet!

My intention was to let the reviewer know that this patch series is based on "master" and not on "maint". Sorry for the confusion!

The patch series "git-p4: kill watchdog and suppress irrelevant output" fixes something annoying that I did not spot earlier. In other words it changes "usable but a bit annoying (dfe90e8)" to "usable".

The patch series "git-p4: ignore P4 changelists that only touch files" changes "usable (4ae048e)" to "maybe even better" depending on the reviewers opinion.

Thanks, Lars