Re: [PATCH] Update diff-highlight
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 22, 2016, 07:50 UTC
- Message-ID
- <xmqqh9h189ph.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <00000153072f5465-fd36f07c-e5e6-4a0f-8cf1-77be99424892-000000@eu-west-1.amazonses.com>
Peter Dave Hello <hsu@peterdavehello.org> writes:
> From: Peter Dave Hello <peterdavehello@users.noreply.github.com> > > Use `#!/usr/bin/env perl` instead of `#!/usr/bin/perl`
Even though there are existing examples in contrib/ parts that use this pattern, we try to avoid use of #!/usr/bin/env in more serious parts of our system. This is to control the exact interpreter used to run our scripts at the build time, and to avoid interference by end users' $PATH environment. So adding more use of #!/usr/bin/env is not quite a welcome move, even if it is to contrib/ part.
Perhaps you can instead mimick the way how contrib/subtree uses the same SHELL_PATH used in the primary Makefile (and config.mak) to turn git-subtree.sh into git-subtree command. Rename the source to diff-highlight.perl, and use PERL_PATH when build procedure turns it into diff-highlight?
I think that is more in line with the rest of the system.