Re: [PATCH] Update diff-highlight

From: Roberto Tyley <roberto.tyley@gmail.com>
Date: Feb 26, 2016, 09:41 UTC
Message-ID: <CAFY1edZ=zs-MyVFmejy32DUyvCjPeb9Kt9J0bFEqVOQMQgW_Og@mail.gmail.com>
In-Reply-To: <CAPig+cRRX4k8jR02YOGTGHUnbOmhHF0oMc-6aCOWuMOpi+BG0A@mail.gmail.com>

On 22 February 2016 at 04:49, Eric Sunshine <sunshine@sunshineco.com> wrote:

Show 8 quoted lines

> On Sun, Feb 21, 2016 at 11:14 PM, Peter Dave Hello
> <hsu@peterdavehello.org> wrote:
>> From: Peter Dave Hello <peterdavehello@users.noreply.github.com>
>
> This "From:" line looks suspiciously incorrect. If anything, you'd
> probably want to drop the line altogether or use:
>
>     From: Peter Dave Hello <hsu@peterdavehello.org>

Peter's commit (https://github.com/git/git/commit/15415c6e) had an author of 'peterdavehello@users.noreply.github.com' (perhaps because the commit was generated through GitHub's interface?), and submitGit added it as an in-body 'From: ' line because it differed from the address used to send the email (hsu@peterdavehello.org - submitGit always uses the user's primary-email-address-in-GitHub to send the email).

A 'noreply' address is obviously not wanted in this context though, so I've updated submitGit to disregard them when deciding whether or not to generate an in-body 'From: ' header: https://github.com/rtyley/submitgit/pull/29

Roberto