Re: [PATCH v7] commit: add a commit.verbose config variable

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 15, 2016, 21:16 UTC
Message-ID: <xmqqh9g77879.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAFZEwPOK1hH8CuFc6TohDc5xq7GXpp0DBnQi4QQ6m+8dspUbeQ@mail.gmail.com>

Pranit Bauva <pranit.bauva@gmail.com> writes:

Show 5 quoted lines

> ... But then I am still not convinced for the
> requirement of another variable `opt-verbose` as I believe that the
> `verbose` and `config_verbose` are quite enough for this.
> ... Or is there something else which I forgot to
> consider?

I do not think we need three variables. If there is one "verbose" that is initialized to "unspecified" (which must be different from "no", "yes", "even more verbose"), then it is perfectly fine to reuse that as if it were "opt-verbose" in my outline. I just used that name to make it clear where the value comes from for these two entities, i.e. to contrast "opt vs config" (as opposed to "(nothing) vs config").