Re: [PATCH v7] commit: add a commit.verbose config variable
- From
Pranit Bauva <pranit.bauva@gmail.com>
- Date
- Mar 15, 2016, 21:18 UTC
- Message-ID
- <CAFZEwPN_OTDxHpYvO2VfZEf5fG0X8fefU65XiLFy0Lt2Fs8Hbg@mail.gmail.com>
- In-Reply-To
- <xmqqh9g77879.fsf@gitster.mtv.corp.google.com>
On Wed, Mar 16, 2016 at 2:46 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 15 quoted lines
> Pranit Bauva <pranit.bauva@gmail.com> writes: > >> ... But then I am still not convinced for the >> requirement of another variable `opt-verbose` as I believe that the >> `verbose` and `config_verbose` are quite enough for this. >> ... Or is there something else which I forgot to >> consider? > > I do not think we need three variables. If there is one "verbose" > that is initialized to "unspecified" (which must be different from > "no", "yes", "even more verbose"), then it is perfectly fine to > reuse that as if it were "opt-verbose" in my outline. I just used > that name to make it clear where the value comes from for these two > entities, i.e. to contrast "opt vs config" (as opposed to "(nothing) > vs config").
I just wanted to clear out the confusion! I will send the updated patch with tests soon!