Re: [PATCH 82/83] environment: add set_index_file()
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 3, 2016, 15:36 UTC
- Message-ID
- <xmqqh9efp30n.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <1461505189-16234-3-git-send-email-chriscool@tuxfamily.org>
Christian Couder <christian.couder@gmail.com> writes:
> +void set_index_file(char *index_file)
> +{
> + git_index_file = index_file;
> +}What's the rationale for this change, and more importantly, the ownership rule for the string? When you call this function, does the caller still own that piece of memory? When you call this twice, where does the old value go and who is responsible for taking care of not leaking it?
Cannot guess any of the above with no proposed log message (that comment applies most of your patches in this series).