Re: [PATCH 80/83] run-command: make dup_devnull() non static

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Apr 25, 2016, 15:05 UTC
Message-ID: <alpine.DEB.2.20.1604251704300.2896@virtualbox>
In-Reply-To: <1461505189-16234-1-git-send-email-chriscool@tuxfamily.org>

Hi Chris,

On Sun, 24 Apr 2016, Christian Couder wrote:

Show 11 quoted lines

> diff --git a/run-command.c b/run-command.c
> index 8c7115a..29d2bda 100644
> --- a/run-command.c
> +++ b/run-command.c
> @@ -85,7 +85,7 @@ static inline void close_pair(int fd[2])
>  }
>  
>  #ifndef GIT_WINDOWS_NATIVE
> -static inline void dup_devnull(int to)
> +void dup_devnull(int to)
>  {

The #ifndef GIT_WINDOWS_NATIVE rings very, very loud alarm bells.

Ciao, Dscho